Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(insights): remove filter based card content #23886

Closed
wants to merge 51 commits into from

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Jul 22, 2024

Problem

Changes

  • fix funnel empty state display "add step", when it shouldn't
  • fix displaying unknown display type -> not possible with query validation
  • fix missing horizontal scrolling for retention insight
  • remove redundant visual regression tests (query based and filter based insight card)
  • fix width of exported funnel insight (3 columns)
  • fix exported insights not taking up full width
  • fix https://posthog.slack.com/archives/C0368RPHLQH/p1721833233860739
  • fix exports
    • funnel trends
    • funnel top-to-bottom
    • funnel time-to-convert
    • funnel left-to-right

How did you test this code?

@thmsobrmlr thmsobrmlr force-pushed the remove-filter-based-card-content branch from b47bddd to 83e8b20 Compare July 23, 2024 08:19
@PostHog PostHog deleted a comment from posthog-bot Jul 23, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 23, 2024
Copy link
Contributor

github-actions bot commented Jul 23, 2024

Size Change: 0 B

Total Size: 1.07 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.07 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@PostHog PostHog deleted a comment from posthog-bot Jul 23, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 23, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 23, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 23, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 23, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 23, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 23, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 23, 2024
@thmsobrmlr thmsobrmlr force-pushed the remove-filter-based-card-content branch from 9fa6585 to a8a5910 Compare July 25, 2024 16:00
@PostHog PostHog deleted a comment from posthog-bot Jul 25, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 25, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 25, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 25, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 25, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 25, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 25, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 25, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 25, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 25, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 25, 2024
@PostHog PostHog deleted a comment from posthog-bot Jul 25, 2024
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

38 snapshot changes in total. 0 added, 38 modified, 0 deleted:

  • chromium: 0 added, 38 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr
Copy link
Contributor Author

Closing in favor of #24050

@thmsobrmlr thmsobrmlr closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants